Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PGV to pick up utf-32 unicode len counting fix #9314

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Bump PGV to pick up utf-32 unicode len counting fix #9314

merged 3 commits into from
Dec 11, 2019

Conversation

wrowe
Copy link
Contributor

@wrowe wrowe commented Dec 11, 2019

Description:

  • resolves Windows build error

Signed-off-by: William A Rowe Jr wrowe@pivotal.io
Signed-off-by: Yechiel Kalmenson ykalmenson@pivotal.io
Signed-off-by: Sunjay Bhatia sbhatia@pivotal.io

Risk Level: Low
Testing: Local on Windows and Linux gcc
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/.

🐱

Caused by: #9314 was opened by wrowe.

see: more, trace.

- resolves Windows build error

Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Yechiel Kalmenson <ykalmenson@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
@sunjayBhatia
Copy link
Member

Rebased on changes from #9311 to include fixes to Windows ci scripts that are required to fix ci

@mattklein123 mattklein123 merged commit daeb985 into envoyproxy:master Dec 11, 2019
@wrowe wrowe deleted the bump-pgv-2019-12-10 branch December 11, 2019 22:32
@sunjayBhatia sunjayBhatia mentioned this pull request Dec 20, 2019
prakhag1 pushed a commit to prakhag1/envoy that referenced this pull request Jan 3, 2020
Signed-off-by: William A Rowe Jr <wrowe@pivotal.io>
Signed-off-by: Yechiel Kalmenson <ykalmenson@pivotal.io>
Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: Prakhar <prakhar_au@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants