Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: remove ApiTypeOracle assert #9973

Merged
merged 5 commits into from
Feb 10, 2020
Merged

config: remove ApiTypeOracle assert #9973

merged 5 commits into from
Feb 10, 2020

Commits on Feb 8, 2020

  1. config: remove ApiTypeOracle assert 

    This assert currently validates that the return value is non-null. However, call sites actually [guard against `nullptr`](https://github.com/envoyproxy/envoy/pull/9618/files#diff-17967d56376bf9821edb17b67b8a7e63R228-R230) and treat it as a valid codepath.

In Envoy Mobile, we're hitting this assert because we use the v3 configuration and don't include all the v2 protos when building the library. Removing the v2 fallback protos in this scenario can be a valid optimization.

Given the above example and the fact that callers explicitly guard against `nullptr`, this assert should be removed and this codepath considered valid.

Signed-off-by: Michael Rebello <me@michaelrebello.com>
    @rebello95
    rebello95 committed Feb 8, 2020
    Configuration menu
    Copy the full SHA
    109cf1c View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2020

  1. update build file 

    Signed-off-by: Michael Rebello <me@michaelrebello.com>
    @rebello95
    rebello95 committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    98d3aaf View commit details
    Browse the repository at this point in the history

  2. logger is still used 

    Signed-off-by: Michael Rebello <me@michaelrebello.com>
    @rebello95
    rebello95 committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    2923d55 View commit details
    Browse the repository at this point in the history

  3. s/logger/assert 

    Signed-off-by: Michael Rebello <me@michaelrebello.com>
    @rebello95
    rebello95 committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    f49e851 View commit details
    Browse the repository at this point in the history

  4. fix dependencies 

    Signed-off-by: Michael Rebello <me@michaelrebello.com>
    @rebello95
    rebello95 committed Feb 9, 2020
    Configuration menu
    Copy the full SHA
    f331d07 View commit details
    Browse the repository at this point in the history