ci: generate should include docs-api #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
Codecov Report
@@ Coverage Diff @@
## main #1246 +/- ##
=======================================
Coverage 63.93% 63.93%
=======================================
Files 79 79
Lines 9931 9931
=======================================
Hits 6349 6349
Misses 3163 3163
Partials 419 419 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zirain
commented
Apr 3, 2023
zirain
commented
Apr 3, 2023
|
thanks for raising this @zirain would it be possible to split this up into 2 PRs so the other useful fix of linking upstream Gateway API docs can be brought in later once the PR you raised has made its way into the upstream repo ? |
|
you can circumvent the situation by ignoring the type/field for now |
zirain
commented
Apr 4, 2023
| @@ -48,5 +48,6 @@ | |||
| "MD047": false, | |||
| "MD048": false, | |||
| "MD049": false, | |||
| "MD050": false | |||
| "MD050": false, | |||
| "MD051": false | |||
There was a problem hiding this comment.
add this line to circumvent lint error
Xunzhuo
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auto update references