[Fix] zero is a falsy but valid propValue.

Fixes #562.
enzymejs · Aug 26, 2016 · f76bc53 · f76bc53
1 parent e5cb263
commit f76bc53
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/MountedTraversal.js b/src/MountedTraversal.js
@@ -100,7 +100,7 @@ export function instHasProperty(inst, propKey, stringifiedPropValue) {
     return false;
   }
 
-  if (propValue) {
+  if (propValue || propValue === 0) {
     return nodePropValue === propValue;
   }
 

diff --git a/src/ShallowTraversal.js b/src/ShallowTraversal.js
@@ -97,7 +97,7 @@ export function nodeHasProperty(node, propKey, stringifiedPropValue) {
     return false;
   }
 
-  if (propValue) {
+  if (propValue || propValue === 0) {
     return nodePropValue === propValue;
   }
 

diff --git a/test/ShallowTraversal-spec.jsx b/test/ShallowTraversal-spec.jsx
@@ -110,6 +110,10 @@ describe('ShallowTraversal', () => {
       expect(nodeHasProperty(<div foo={2e8} />, 'foo', '2e8')).to.equal(true);
       expect(nodeHasProperty(<div foo={Infinity} />, 'foo', 'Infinity')).to.equal(true);
       expect(nodeHasProperty(<div foo={-Infinity} />, 'foo', '-Infinity')).to.equal(true);
+      expect(nodeHasProperty(<div foo={0} />, 'foo', '0')).to.equal(true);
+      expect(nodeHasProperty(<div foo={-0} />, 'foo', '-0')).to.equal(true);
+      expect(nodeHasProperty(<div foo={1} />, 'foo', '0')).to.equal(false);
+      expect(nodeHasProperty(<div foo={2} />, 'foo', '-0')).to.equal(false);
     });
 
     it('should throw when un unquoted string is passed in', () => {