Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to babel 6 #78

Closed
tmcw opened this issue Dec 17, 2015 · 3 comments
Closed

Update to babel 6 #78

tmcw opened this issue Dec 17, 2015 · 3 comments

Comments

@tmcw
Copy link
Contributor

tmcw commented Dec 17, 2015

Ideally enzyme would update to babel 6 so that it can be compatible with applications built in babel 6 land and their configuration files.
@ljharb
Copy link
Member

ljharb commented Dec 17, 2015

Why would the babel version used matter, since the transpiled version is what's published, and node_modules shouldn't ever be transpiled?

@goatslacker
Copy link
Contributor

We should probably upgrade regardless but not for that reason.

lecstor added a commit to lecstor/enzyme that referenced this issue Dec 18, 2015
@lecstor
Update to babel 6 enzymejs#78
b43040c 
- tests pass with React 13 & 14
- npm run travis produces coverage
- npm link works
lecstor added a commit to lecstor/enzyme that referenced this issue Jan 7, 2016
@lecstor
Update to babel 6 enzymejs#78
4e05729 
- tests pass with React 13 & 14
- npm run travis produces coverage
- npm link works
lecstor added a commit to lecstor/enzyme that referenced this issue Jan 8, 2016
@lecstor
Update to babel 6 enzymejs#78
9df0d2c 
- tests pass with React 13 & 14
- npm run travis produces coverage
- npm link works
lecstor added a commit to lecstor/enzyme that referenced this issue Jan 21, 2016
@lecstor
Update to babel 6 enzymejs#78
87d4208 
- tests pass with React 13 & 14
- npm run travis produces coverage
- npm link works
lecstor added a commit to lecstor/enzyme that referenced this issue Jan 21, 2016
@lecstor
Update to babel 6 enzymejs#78
11bf7b9 
- tests pass with React 13 & 14
- npm run travis produces coverage
- npm link works
lecstor added a commit to lecstor/enzyme that referenced this issue Jan 22, 2016
@lecstor
Update to babel 6 enzymejs#78
67451ef 
- tests pass with React 13 & 14
- npm run travis produces coverage
- npm link works
- use airbnb Babel6 preset
- modify react-compat to export functions individually
- update test commands to use babel-core
lecstor added a commit to lecstor/enzyme that referenced this issue Jan 22, 2016
@lecstor
Update to babel 6 enzymejs#78
c0b30bc 
- tests pass with React 13 & 14
- npm run travis produces coverage
- npm link works
- use airbnb Babel6 preset
- modify react-compat to export functions individually
- update test commands to use babel-core
lelandrichardson added a commit that referenced this issue Jan 22, 2016
@lelandrichardson
Merge pull request #81 from lecstor/master
884d6f2 
Update to babel 6 #78
@lelandrichardson
Copy link
Collaborator

PR Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@goatslacker @tmcw @ljharb @lelandrichardson