Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add callback arg to setProps header in mount.md #1361

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

DannyDelott
Copy link
Contributor

Match the signature as expressed insetProps.md

@@ -170,7 +170,7 @@ Simulates an event on the current node.
#### [`.setState(nextState) => ReactWrapper`](ReactWrapper/setState.md)
Manually sets state of the root component.

#### [`.setProps(nextProps) => ReactWrapper`](ReactWrapper/setProps.md)
#### [`.setProps(nextProps[, callback]) => ReactWrapper`](ReactWrapper/setProps.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, does a similar change need to be made in the shallow docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without looking at any of the code, the documentation for shallow's setProps does not describe a callback argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants