Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing .at(0).exists() test #1478

Merged
merged 2 commits into from
Jul 7, 2018
Merged

Add failing .at(0).exists() test #1478

merged 2 commits into from
Jul 7, 2018

Conversation

KordonDev
Copy link
Contributor

This pull request adds a test for the issue #1475 but doesn't fix it.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an additional test under .at that asserts on the length of .at(0) for this case?

@@ -2817,6 +2817,17 @@ describe('shallow', () => {
});
});

describe('at(0).exists()', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this test to be under exists?

@KordonDev
Copy link
Contributor Author

I moved it to .at()

@ljharb
Copy link
Member

ljharb commented Jan 27, 2018

I'm hoping for two tests here; one under exists and another under at.

@ljharb
Copy link
Member

ljharb commented Jul 7, 2018

I'm tweaking this a bit. wrapper.find('.foo') is supposed to find nothing, because .find does not consider the wrapper itself - and the wrapper is a .foo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants