ShallowRenderer.simulate supports batched updates

[koba04]

This PR is for ShallowWrapper.simulate() supports batched updates using ReactUpdates.batchedUpdates.

React.addons.TestUtils.Simulate.{eventName} is supporting batched updates.
ref. https://jsfiddle.net/koba04/6Lchbest/

ReactUpdates.batchedUpdates is exported as ReactDOM. unstable_batchedUpdates from React v0.14. In React v0.13, it is exported as React.addons.batchedUpdates.

It might be better I use the exported interface.
But I guess it makes your configurations complex than using ReactUpdates.batchedUpdates directly.

FYI: This batched updates feature is required #318.

Thanks.

[lelandrichardson]

Interesting. So you are planning on using this to ensure that the batching behavior of setState is accurately depicted in #318?

[koba04]

@lelandrichardson

So you are planning on using this to ensure that the batching behavior of setState is accurately depicted in #318?

Yes, it would be nice if I could ensure that.
But I'm not sure that it is possible because I'm trying it yet.

This is relevant to #318 but independent.

[blainekasten]

This might become an issue due to facebook/react#6460. depending on which way they go. Hopefully this might help sway them away.

[aweary]

I think we'll likely have to be reactive when it comes to facebook/react#6460. We should definitely try to work with the React team if they want to support libraries like enzyme in some capacity.

Also @koba04 can you put this require up at the top with the main const React = require('react') statement, since this is not a version dependant import at all.

[koba04]

@aweary I've updated it!

[aweary]

Since there is a public API for batchedUpdates maybe we should just wrap the batchedUpdates assignment call in the REACT013 check and use the appropriate access points mentioned in the OP. It's more complicated but at least we can avoid reaching into React/lib for now.

What do you think @blainekasten @lelandrichardson @koba04?

[koba04]

@aweary I've updated this PR to use public APIs for batchedUpdates! It's not complicated for me 😄

[aweary]

LGTM

[nfcampos]

LGTM

[nfcampos]

I'll have to find out whether react batches updates for all handlers triggered by an event for #368, if anyone knows let me know

[aweary]

@nfcampos a cursory glance suggest that they do but we'll have to investigate that further to verify.

[aweary]

@ljharb @lelandrichardson it doesn't seem like the LGTM check seems to be working?

[lelandrichardson]

LGTM

[lelandrichardson]

@aweary it looks like there's still some configuration we need to do with it to add you guys. i'll see if @ljharb can finish that today. thanks!

[ljharb]

@aweary turns out that the issue is lgtmco/lgtm#19 - i'll update our MAINTAINERS file in the meantime.

[koba04]

rebased

[aweary]

@koba04 can you rebase please? I think we can merge this afterwards.

[koba04]

@aweary rebased!

[aweary]

Thanks @koba04!

[koba04]

Thanks for your help 🎉