Update project to scala version 3.5.1. Rewrite depreciated syntax. #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
SimonGuilloud
commented
Oct 3, 2024
SimonGuilloud
commented
- Update project to scala version 3.5.1.
- Rewrite depreciated syntax.
- Hide scallion warning report.
- Hide some unjustified error report.
sankalpgambhir
approved these changes
Oct 4, 2024
| @@ -33,35 +33,35 @@ object Lattices extends lisa.Main { | |||
| val reflexivity = Axiom(x <= x) | |||
| val antisymmetry = Axiom(((x <= y) /\ (y <= x)) ==> (x === y)) | |||
| val transitivity = Axiom(((x <= y) /\ (y <= z)) ==> (x <= z)) | |||
| val lub = Axiom(((x <= z) /\ (y <= z)) <=> ((x u y) <= z)) | |||
| val glb = Axiom(((z <= x) /\ (z <= y)) <=> (z <= (x n y))) | |||
| val lub = Axiom(((x <= z) /\ (y <= z)) <=> ((x `u` y) <= z)) | |||
There was a problem hiding this comment.
Why not just change u and n to be infix?
| "-language:implicitConversions" | ||
| "-language:implicitConversions", | ||
| //"-rewrite", "-source", "3.4-migration", | ||
| "-Wconf:msg=.*will never be selected.*:silent" |
There was a problem hiding this comment.
Do we really need this if the @nowarns are added already below? It may be better to not have the generic warning suppression for later development
There was a problem hiding this comment.
there is one warning steeming from a "export" that the nowarn does not silence, unfortunately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.