Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download and infer from remote models #545

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Conversation

s314cy
Copy link
Contributor

@s314cy s314cy commented Nov 15, 2022

List of changes

  • server
    • prints prettier console messages
  • web-client/validation
    • displays a list of the latest models available on the remote server (one for each task)
    • allows the user to directly validate one of such remote models
    • uses the composition API
  • discjos/memory
    • supports saved model duplicates

Related issue

Fixes #497

@s314cy s314cy added feature New feature or request web client Related to the browser environment labels Nov 15, 2022
@s314cy s314cy self-assigned this Nov 15, 2022
@s314cy s314cy force-pushed the 497-download-models-s314cy branch 3 times, most recently from 8c7bf16 to 133a278 Compare November 15, 2022 16:06
@s314cy s314cy marked this pull request as ready for review November 16, 2022 13:26
@s314cy s314cy force-pushed the 497-download-models-s314cy branch 2 times, most recently from 8dad6af to 9be0873 Compare November 16, 2022 13:31
@Annie-LiGHT
Copy link
Collaborator

Wow. This is beautiful! 💅

Some minor comments

  • Change "Registered models" --> "Selected models"
  • There is "placeholder" text that says "placeholder". not sure if that remains visible on the platform?
  • It is slightly unclear that the "registered model" box includes the models cards underneath (a box is usually enclosing its content, whereas here it is acting as a heading). Is there a way to either put the model cards in the box or remove the box and put free-floating heading with a line separating them?

@s314cy
Copy link
Contributor Author

s314cy commented Nov 16, 2022

Thanks for the feedback!

Change "Registered models" --> "Selected models"

I would go with "Models Stored Locally" and "Remote Models"? Both texts will have an explanation below anyway.

There is "placeholder" text that says "placeholder". not sure if that remains visible on the platform?

It won't appear on the platform :)

It is slightly unclear that the "registered model" box includes the models cards underneath (a box is usually enclosing its content, whereas here it is acting as a heading). Is there a way to either put the model cards in the box or remove the box and put free-floating heading with a line separating them?

I'll try and include the models in their boxes!

@Annie-LiGHT
Copy link
Collaborator

Annie-LiGHT commented Nov 16, 2022

hmmm "remote model" might imply that it is working remotely.

Maybe

  • "Your model library (downloaded and ready to train)"

  • "Select a model from the DISCO repository to add to your library"

@s314cy
Copy link
Contributor Author

s314cy commented Nov 16, 2022

hmmm "remote model" might imply that it is working remotely.

Maybe

* "Your model library _(downloaded and ready to train)_"

* "Select a model from the DISCO repository to add to your library"

What do you think?

Screenshot 2022-11-16 at 15 24 19

@Annie-LiGHT
Copy link
Collaborator

NICE!
Micro comment: "DISCO model repository" sounds a bit better

@s314cy s314cy merged commit 7d448c5 into develop Nov 18, 2022
@s314cy s314cy deleted the 497-download-models-s314cy branch November 18, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request web client Related to the browser environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloadable models in the validation panel
3 participants