Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: use npm workspaces #617

Merged
merged 4 commits into from
Feb 14, 2024
Merged

*: use npm workspaces #617

merged 4 commits into from
Feb 14, 2024

Conversation

tharvik
Copy link
Collaborator

@tharvik tharvik commented Feb 2, 2024

  • no need for npm link anymore
  • allow to build all projects via npm -ws run build (or test, or any script really)
  • allow to easily import packages (simply import @epfml/disco-core) by using a common node_modules for shared deps
  • watch files changes and run npm script in most packages, for eg npm -w ./discojs/discojs-core run watch build
  • change much of the github action to better reflect the stages dependencies (we can't lint discojs-core without build discojs-node for example)

@JulienVig
Copy link
Collaborator

JulienVig commented Feb 5, 2024

Amazing! Can you update DEV.md with an updated install.sh description?
Edit: never mind, I need to merge the documentation branch beforehand

@tharvik
Copy link
Collaborator Author

tharvik commented Feb 5, 2024

Amazing! Can you update DEV.md with an updated install.sh description?

Thanks, yep, will do!

I will also first discuss it with @peacefulotter as it probably conflicts with the bun integration PR.

@tharvik
Copy link
Collaborator Author

tharvik commented Feb 7, 2024

I've also added a way to watch for changes and build/lint/test accordingly. One can use it via npm run watch build in every pkg.

@tharvik tharvik mentioned this pull request Feb 7, 2024
18 tasks
@tharvik tharvik mentioned this pull request Feb 8, 2024
@tharvik tharvik force-pushed the add-workspaces branch 6 times, most recently from 691e660 to 8d60ed1 Compare February 12, 2024 11:09
@tharvik tharvik mentioned this pull request Feb 12, 2024
@tharvik tharvik force-pushed the add-workspaces branch 3 times, most recently from 3a48d6c to 0649ab4 Compare February 12, 2024 12:42
Base automatically changed from 606-update-doc-julien to develop February 12, 2024 14:52
@tharvik tharvik mentioned this pull request Feb 13, 2024
@tharvik tharvik force-pushed the add-workspaces branch 4 times, most recently from d5ae78c to c42de2d Compare February 13, 2024 14:54
@tharvik tharvik marked this pull request as ready for review February 13, 2024 14:54
Copy link
Collaborator

@JulienVig JulienVig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! This is going to make things so much smoother, thanks! I left a few non-blocking questions and suggestions.

discojs/publish.ts Outdated Show resolved Hide resolved
docs/ONBOARDING.md Outdated Show resolved Hide resolved
docs/ONBOARDING.md Outdated Show resolved Hide resolved
tharvik and others added 3 commits February 14, 2024 11:11
Co-authored-by: Julien Vignoud <33122365+JulienVig@users.noreply.github.com>
@tharvik tharvik merged commit addbdac into develop Feb 14, 2024
20 checks passed
@tharvik tharvik deleted the add-workspaces branch February 14, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants