Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve UI bugs and add UI error feedback #624

Merged
merged 20 commits into from
Feb 14, 2024
Merged

Conversation

JulienVig
Copy link
Collaborator

@JulienVig JulienVig commented Feb 8, 2024

Addresses web-client bugs and broken features. Fixes various typos.

@JulienVig JulienVig added bug Something isn't working web client Related to the browser environment discojs Related to Disco.js labels Feb 8, 2024
@JulienVig JulienVig self-assigned this Feb 8, 2024
@JulienVig JulienVig marked this pull request as ready for review February 13, 2024 17:33
Copy link
Collaborator

@tharvik tharvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, we need more errors (at least, make theses visible), thanks!

review: not blocking, just some potential improvements

discojs/discojs-core/src/training/disco.ts Outdated Show resolved Hide resolved
discojs/discojs-core/src/training/disco.ts Outdated Show resolved Hide resolved
discojs/discojs-core/src/validation/validator.ts Outdated Show resolved Hide resolved
web-client/src/components/testing/Tester.vue Outdated Show resolved Hide resolved
web-client/src/components/testing/Tester.vue Outdated Show resolved Hide resolved
web-client/src/components/testing/Tester.vue Outdated Show resolved Hide resolved
web-client/src/main.ts Outdated Show resolved Hide resolved
JulienVig and others added 6 commits February 14, 2024 11:56
@JulienVig JulienVig merged commit a027c6c into develop Feb 14, 2024
20 checks passed
@JulienVig JulienVig deleted the 611-ui-crashes-julien branch February 14, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discojs Related to Disco.js web client Related to the browser environment
Projects
None yet
2 participants