Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUS COVID demo #660

Merged
merged 31 commits into from
May 1, 2024
Merged

LUS COVID demo #660

merged 31 commits into from
May 1, 2024

Conversation

JulienVig
Copy link
Collaborator

@JulienVig JulienVig commented Apr 23, 2024

Bug fixes to set up the LUS COVID demo for next week

  • Add test cases lus_covid (image_loader, validator, end to end training)
  • Fix node image_loader default channel error (default to 1 while it should be 3)
  • Add lus_covid task to CLI
  • Fine-tune hyper parameters
  • Image dataset shuffling is done by hand while tfjs already implements it
  • Fix label encoding mistake (using tf.oneHot on 'positive' and 'negative' yields the same label for both class)
  • "Train Collaboratively" raises an error
  • Training loss and other metrics stay constant after the first few epochs
  • Model always predicts positive
  • Training collaboratively with two web-client results in timeouts (server drop client contributions)
  • UI number of participants doesn't get updated as they join a task
  • web-client training performance stays constant while training via node.js works well

Model used to only predict the majority class (~0.5 accuracy), by normalizing image values from 0-255 to 0-1 the training now yields >0.9 on both training and validation sets

@JulienVig JulienVig marked this pull request as ready for review April 26, 2024 11:46
@JulienVig JulienVig requested a review from tharvik April 26, 2024 11:46
Copy link
Collaborator

@tharvik tharvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

génial, thanks for the hard work!

server/src/tasks.ts Outdated Show resolved Hide resolved
@JulienVig JulienVig self-assigned this Apr 29, 2024
@JulienVig JulienVig added discojs Related to Disco.js bug Something isn't working labels Apr 29, 2024
@JulienVig JulienVig merged commit 59d7543 into develop May 1, 2024
23 checks passed
@JulienVig JulienVig deleted the lus-demo-julien branch May 1, 2024 14:46
@martinjaggi
Copy link
Member

super nice, congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discojs Related to Disco.js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants