Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Skin Condition classification task #678

Merged
merged 20 commits into from
May 31, 2024
Merged

Create a Skin Condition classification task #678

merged 20 commits into from
May 31, 2024

Conversation

JulienVig
Copy link
Collaborator

@JulienVig JulienVig commented May 27, 2024

Add a skin condition multi-class classification task as a predefined task in Disco for the upcoming demo. The SCIN dataset is described here.

  • original model previously used for this task currently only predicts the benign class
  • create a sample image dataset to provide to users (original dataset is 3GB and requires creating an account on Kaggle and creating the csv label mapping file) -> Available on the google cloud bucket
  • Testing a model fails with error
  • fine tune architecture and hp. I tried using a pre-trained mobilenet (a334219, commented code in skin_mnist.ts) but encountered Discrepancy between training logs and manually evaluating metrics #679 and decided to settle on a smaller handmade CNN for now.
    For 800 images
    Screenshot 2024-05-30 at 12 31 58
  • Allow connecting a folder rather than individual files -> moved to Connecting folder displays alarming "Upload" warning message #680
  • Add an example of how to create csv file to connect data -> docs/dataset_csv_creation.ipynb
  • At test time, show label names rather than integer numbers
    Before:
    Screenshot 2024-05-30 at 11 29 53
    Now:
    Screenshot 2024-05-30 at 12 33 24

@JulienVig JulienVig marked this pull request as ready for review May 30, 2024 11:04
Copy link
Collaborator

@tharvik tharvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done (and sorry that you had to rush it)! a bit of cleanup but nothing vital

discojs/src/default_tasks/skin_mnist.ts Outdated Show resolved Hide resolved
discojs/src/default_tasks/skin_mnist_mobilenet/model.json Outdated Show resolved Hide resolved
discojs/src/validation/validator.ts Show resolved Hide resolved
@JulienVig JulienVig changed the title Integrate the skin disease classification task Create a Skin Condition classification task May 30, 2024
@JulienVig
Copy link
Collaborator Author

@tharvik do you want to review the latest changes or shall I merge the PR?

@tharvik tharvik merged commit 1f0f0e5 into develop May 31, 2024
23 checks passed
@tharvik tharvik deleted the swiss-tph-demo branch May 31, 2024 08:59
@JulienVig JulienVig mentioned this pull request Jun 5, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants