Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webapp/ModelLibrary: add some tests #681

Merged
merged 3 commits into from
Jun 3, 2024
Merged

webapp/ModelLibrary: add some tests #681

merged 3 commits into from
Jun 3, 2024

Conversation

tharvik
Copy link
Collaborator

@tharvik tharvik commented May 30, 2024 •
edited
Loading

some quick test for next hackathon to check that models downloaded via the model library are valid TensorFlow models.

issues found during:

  • after training, the model library is not populated reactively, one need to refresh the page to make it appear
    • not trivial to fix as Memory and MemoryStore, the latter being watchable, are mixed throughout
  • the model is saved to memory anyway, not solely when clicking "save model"

@tharvik tharvik self-assigned this May 30, 2024
@tharvik tharvik force-pushed the NAN-add-model-download-test-tharvik branch from 6afaf46 to 7543b66 Compare May 31, 2024 10:24
@tharvik tharvik force-pushed the NAN-add-model-download-test-tharvik branch from 7543b66 to c58542c Compare May 31, 2024 10:27
@tharvik tharvik marked this pull request as ready for review May 31, 2024 10:28
JulienVig
JulienVig approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@JulienVig JulienVig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks a lot for the work!

webapp/src/components/sidebar/ModelLibrary.vue Outdated Show resolved Hide resolved
webapp/src/components/sidebar/ModelLibrary.vue Outdated Show resolved Hide resolved
@tharvik tharvik force-pushed the NAN-add-model-download-test-tharvik branch from c58542c to 77a9fa5 Compare June 3, 2024 11:36
@tharvik tharvik merged commit dad8940 into develop Jun 3, 2024
23 checks passed
@tharvik tharvik deleted the NAN-add-model-download-test-tharvik branch June 3, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienVig JulienVig JulienVig approved these changes

Assignees

@tharvik tharvik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tharvik @JulienVig