feat(rpc): Rewrite Ethereum client for subs-based state updates #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t00ts
force-pushed
the
t00ts/ethereum-ws
branch
2 times, most recently
from
538e5fb
to
b027edd
Compare
sistemd
reviewed
Sep 9, 2024
sistemd
reviewed
Sep 9, 2024
kkovaacs
reviewed
Sep 9, 2024
t00ts
force-pushed
the
t00ts/ethereum-ws
branch
3 times, most recently
from
c53fcc5
to
a98867a
Compare
t00ts
force-pushed
the
t00ts/ethereum-ws
branch
from
5733cef
to
faecac7
Compare
t00ts
changed the title
kkovaacs
reviewed
Sep 11, 2024
… Updates when they belong in a finalized block
t00ts
force-pushed
the
t00ts/ethereum-ws
branch
from
faecac7
to
ac6dd5e
Compare
kkovaacs
reviewed
Sep 11, 2024
There was a problem hiding this comment.
LGTM % some nits.
There are also some missing parts:
- This is an incompatible change (we now explicitly require a Websocket URL). We should probably add more refined handling of that: updating the documentation for the
--ethereum.urlargument, or maybe trying to update the scheme of the URL fromhttp->wsandhttps->wssand printing a big fat warning. In any case, we should make sure that we exit with a very clear error message in case the URL does not work. In general we should be doing everything we can to make the life of end users easier. - Updating the CHANGELOG file with information about the incompatible change (we now require a Websocket URL for the Ethereum API).
| @@ -126,7 +126,6 @@ impl Transaction<'_> { | |||
| ":idx": &idx, | |||
| ])?; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This is probably just a leftover.
kkovaacs
reviewed
Sep 11, 2024
t00ts
force-pushed
the
t00ts/ethereum-ws
branch
from
81a1d4f
to
0d32ed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a comprehensive rewrite of the Ethereum client, transitioning to a subscription-based approach using the Alloy library.
This translates to efficiency improvements when tracking and updating Ethereum state in real-time, especially for L1 to L2 interactions.
Key features include:
See also:
#2182
#2216