API logic for redundant connection to single deviec (same device ID f…

…or both primary and secondary conn)

CHANGELOG.md

@@ -1,3 +1,10 @@
+## 2.0.3 (March 03, 2021)
+
+BUG FIXES:
+
+* creation of redundant connection from a single device is now reflecting
+upstream API logic
+
 ## 2.0.2 (February 24, 2021)
 
 NOTES:

rest_l2_connection.go

@@ -205,7 +205,9 @@ func createL2RedundantConnectionRequest(primary L2Connection, secondary L2Connec
 	connReq := createL2ConnectionRequest(primary)
 	connReq.SecondaryName = secondary.Name
 	connReq.SecondaryPortUUID = secondary.PortUUID
-	connReq.SecondaryVirtualDeviceUUID = secondary.DeviceUUID
+	if StringValue(primary.DeviceUUID) != StringValue(secondary.DeviceUUID) {
+		connReq.SecondaryVirtualDeviceUUID = secondary.DeviceUUID
+	}
 	connReq.SecondaryVlanSTag = secondary.VlanSTag
 	connReq.SecondaryVlanCTag = secondary.VlanCTag
 	connReq.SecondaryZSidePortUUID = secondary.ZSidePortUUID

rest_l2_connection_test.go

@@ -364,3 +364,29 @@ func verifyL2ConnectionAction(t *testing.T, action L2ConnectionAction, apiAction
 		assert.Equal(t, action.RequiredData[i].ValidationPattern, apiAction.ActionRequiredData[i].ValidationPattern, "ValidationPattern matches")
 	}
 }
+
+func TestCreateL2RedundantConnectionRequest_oneDevice(t *testing.T) {
+	//given
+	primary := L2Connection{
+		Name:              String("primary"),
+		ProfileUUID:       String("profileID"),
+		DeviceUUID:        String("deviceID"),
+		DeviceInterfaceID: Int(4),
+		Speed:             Int(50),
+		SpeedUnit:         String("Mbps"),
+		SellerMetroCode:   String("SV"),
+		SellerRegion:      String("us-west1"),
+		AuthorizationKey:  String("authKey"),
+	}
+	secondary := L2Connection{
+		Name:              String("secondary"),
+		DeviceUUID:        primary.DeviceUUID,
+		DeviceInterfaceID: Int(5),
+	}
+	//when
+	request := createL2RedundantConnectionRequest(primary, secondary)
+	//then
+	assert.Nil(t, request.SecondaryVirtualDeviceUUID, "Secondary device UUID is not set")
+	assert.Equal(t, secondary.Name, request.SecondaryName, "Secondary name matches")
+	assert.Equal(t, secondary.DeviceInterfaceID, request.SecondaryInterfaceID, "Secondary deviceInterfaceID name matches")
+}