Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates of VectorCalculator based on SmartNodeSelector enhancement #608

Closed
jorgenherje opened this issue Oct 20, 2021 · 4 comments
Closed
Assignees
Labels
CeeSol Task owned by Ceetron Solutions enhancement New feature or request

Comments

@jorgenherje
Copy link
Collaborator

jorgenherje commented Oct 20, 2021

Update VectorCalculator based on enhancement/fix in SmartNodeSelector

Based on: equinor/webviz-core-components#178 and equinor/webviz-core-components#181

  • With update of SmartNodeSelector with its suggestion popup placed on top, the VectorSelector utilized in VectorCalculator can be placed in an max height are or scroll field, as suggestion popup will not trigger scroll area.
  • Add usage of "TreeData" and "TreeDataNode" as it is exported?
  • Set case-insensitive search
  • Set placeholder: "Add new vector..."
@jorgenherje jorgenherje added enhancement New feature or request CeeSol Task owned by Ceetron Solutions labels Oct 20, 2021
@jorgenherje jorgenherje self-assigned this Oct 20, 2021
@jorgenherje jorgenherje changed the title Place vector selectors for expression within max-length/scroll area Minor updates of VectorCalculator based on SmartNodeSelector enhancement Oct 20, 2021
@rubenthoms
Copy link
Collaborator

Consider also adding a dialog asking if the user wants to save changes when switching to a different expression in the list and not having saved changes yet.

@jorgenherje
Copy link
Collaborator Author

jorgenherje commented Nov 17, 2021

  • When external parsing is utilized, the default expression for "New expression" should be parsed/validated? Now it shows valid and is not parsed until editing is started
  • Fix textcolor when hovering buttons. white text becomes black (buttons with dark background color) - only in Dash

@jorgenherje
Copy link
Collaborator Author

jorgenherje commented Feb 16, 2022

TODO:

  • With update of SmartNodeSelector with its suggestion popup placed on top, the VectorSelector utilized in VectorCalculator can be placed in an max height are or scroll field, as suggestion popup will not trigger scroll area.
  • Add usage of "TreeData" and "TreeDataNode" as it is exported
  • caseInsensitiveMatching (awaits Add missing props to VectorSelector #823)
  • Set placeholder: "Add new vector..."
  • Wrong text color when hovering buttons - text becomes dark
  • Adjust height difference of papers
  • Parse default expression for "New expression" with external parser?
  • Add dialog asking if user wants to save changes when switching to new expression without saving changes

@jorgenherje
Copy link
Collaborator Author

Closed by #860

hkfb pushed a commit that referenced this issue Jul 30, 2024
hkfb pushed a commit that referenced this issue Jul 30, 2024
hkfb pushed a commit that referenced this issue Jul 30, 2024
hkfb pushed a commit that referenced this issue Jul 30, 2024
hkfb pushed a commit that referenced this issue Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CeeSol Task owned by Ceetron Solutions enhancement New feature or request
Projects
Status: Done 🏁
Development

No branches or pull requests

2 participants