-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .andFulfill(expectation) #421
Conversation
This is good to go. I'm still making my mind up whether to release OCMock 3.6.1 with some of the fixes and developer experience improvements, or whether I do 3.7 straight away with new features. This is obviously a new feature. Marking it blocked until 3.7 is definitely the next release. |
1ce49cf
to
adc0382
Compare
This PR introduces a dependency on XCTest. As discussed in #420 this is not a problem. (In fact, it will help get off some deprecated API.) However, when I merged this PR I noticed the following warning:
It looks like XCTest is built for the current SDK (I'm not on Big Sur yet) while OCMock is built with 10.10 as deployment target. Anyone think this a problem? Something else I noticed: how did you add XCTest for watchOS? When I tried this earlier I could not see XCTest for the watchOS target. It showed up for all other targets in the dialog that appears when you add a framework in the link build phase, but not for watchOS. Re-checked now and it's still the case for me. |
Suggested implementation for erikdoe#420
bf347b4
to
32fe837
Compare
I don't think mixing OCMock at 10.10 with the newest XCTest is going to be a problem, otherwise you couldn't mix XCTest with any code that had a lower deployment target. I must admit I didn't test building the watchOS version. You are correct that watchOS doesn't have XCTest support (for reasons that I never quite understood). I have added guards around the calls appropriately assuming that we want to support watchOS even if there is no official XCTest support for it. |
Suggested implementation for #420