Allow code_reload.node to be a list of nodes
#1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @mkuratczyk ! |
It can now be either
```
code_reload:
node: node@localhost
```
or
```
code_reload:
node:
- node-1@localhost
- node-2@localhost
```
|
Done. Thank you! |
|
Thanks for your contribution @mkuratczyk ! CI seems to be a failing on coveralls for some reason, I will merge anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. When working on clustered applications (RabbitMQ in my case), it's useful to reload the code on all nodes in the cluster. Otherwise I can't really use reloading since I still need to restart the other nodes to pick up the changes. This is a very rudimentary change that gets the job done for me (I've been happily using it for a few days). Would you accept something like that?
I decided to "overload" the
code_reload.nodesetting and allow it to be a list. Alternatively, we could have a separate field (code_reload.nodes) but then we would need to handle both being set for example. I'm happy to make such changes if you prefer.Thanks,