Bump erlfmt to upstream 1.3.0 #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomoripeti
force-pushed
the
erlfmt_1_3_0
branch
from
e96bbf9
to
af61c4a
Compare
Supported added to erlfmt WhatsApp/erlfmt#341
gomoripeti
force-pushed
the
erlfmt_1_3_0
branch
from
9a141fa
to
d2f9a11
Compare
|
Only failing testcase is els_docs_SUITE ==> invalidate: FAILED timing out on OTP 23, but it seems to fail on main as well. So this PR is read for review. (Don't have to wait for erlfmt PR as the dialyzer warning is silenced, thanks for the idea :) ) |
|
Good stuff @gomoripeti ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since previous version used erlfmt added support for map comprehensions, maybe expressions and some exotic macros.
There are some dialyzer warnings pending WhatsApp/erlfmt#352.
Variable scope handling was recently improved in erlang_ls for list comprehensions. It needs to be extended to binary and map comprehensions as well, which this PR does not address.
Fixes # .