OTP27 support #1530
Merged
OTP27 support #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contributions @MarkoMin . I see there seems. to be a problem with the build workflow, I will try to solve it. |
|
Fix for the workflows is merged now. |
MarkoMin
force-pushed
the
otp27_support
branch
from
f3debe8
to
865c8b4
Compare
|
seems like there is some issue with artifact caching in the workflow. Can you restart it? |
|
Sorry, can you rebase again? It should be fixed now. |
MarkoMin
force-pushed
the
otp27_support
branch
from
7f6ddbb
to
4d2ce31
Compare
|
Thanks for you contribution @MarkoMin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Things done:
-docand-moduledoc(+ tests)erlfmtwhich fully supports OTP27Things to be done:
Things I need help with:
els_diagnostics_SUITE- those even fail for me when I run them on currentmainbranch with OTP25 (tescases fail due to "can't find include file" error, while test cases expect them to be found)els_completion_SUITE- some functions fail when comparing documentation (e.g.application_remote_otp- Seems like only signature is fetched as a markdown in OTP27, dunno exactly why. Any help here is very welcomeFixes #1489.