Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spread rest obj type elem #323

Merged
merged 6 commits into from
Aug 8, 2024
Merged

spread rest obj type elem #323

merged 6 commits into from
Aug 8, 2024

Conversation

kevinbarabash
Copy link
Contributor

  • wip
  • add SpreadRest ObjTypeElem and update Infer.fs and Unify.fs to use that instead of intersection types

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 78.64769% with 60 lines in your changes missing coverage. Please review.

Project coverage is 83.93%. Comparing base (4190d3e) to head (74d1698).

Files Patch % Lines
src/Escalier.TypeChecker/Unify.fs 81.00% 38 Missing ⚠️
src/Escalier.TypeChecker/BuildGraph.fs 42.85% 8 Missing ⚠️
src/Escalier.Codegen/Codegen.fs 0.00% 5 Missing ⚠️
src/Escalier.Data/Library.fs 40.00% 3 Missing ⚠️
src/Escalier.TypeChecker/Infer.fs 92.50% 3 Missing ⚠️
src/Escalier.TypeChecker/Visitor.fs 60.00% 2 Missing ⚠️
src/Escalier.TypeChecker/Folder.fs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   84.16%   83.93%   -0.23%     
==========================================
  Files          23       23              
  Lines       11625    11768     +143     
  Branches     1603     1647      +44     
==========================================
+ Hits         9784     9878      +94     
- Misses       1841     1890      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevinbarabash kevinbarabash merged commit 715bb44 into main Aug 8, 2024
1 check passed
@kevinbarabash kevinbarabash deleted the spread-rest-obj-type-elem branch August 8, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants