Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for now whitelist citations to only the DRKZ server #474

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Conversation

sashakames
Copy link
Collaborator

@sashakames sashakames commented Sep 20, 2022

Description

We need to correct the citation URL API

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Local Pre-commit Checks
  • CI/CD Build

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • If applicable - I have commented my code, particularly in hard-to-understand areas
  • If applicable - I have made corresponding changes to the documentation
  • If applicable - I have added tests that prove my fix is effective or that my feature works
  • If applicable - New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #474 (561c320) into master (dd2f7c2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #474   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         1703      1707    +4     
  Branches       322       322           
=========================================
+ Hits          1703      1707    +4     
Flag Coverage Δ
backend 100.00% <100.00%> (ø)
frontend 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/metagrid/api_proxy/views.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sashakames
Copy link
Collaborator Author

@downiec Can we look to deploy this on aims2?

@downiec downiec merged commit 8bb7aa9 into master Sep 23, 2022
@downiec downiec deleted the citation_patch branch September 23, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants