Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the facet count to the copy facet list button. #604

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

downiec
Copy link
Collaborator

@downiec downiec commented Feb 6, 2024

Also updated test to pass with new facet count output.

Fixes # 591

Type of change

  • New feature (non-breaking change which adds functionality

How Has This Been Tested?

  • Local Pre-commit Checks
  • CI/CD Build

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • If applicable - I have commented my code, particularly in hard-to-understand areas
  • If applicable - I have made corresponding changes to the documentation
  • If applicable - I have added tests that prove my fix is effective or that my feature works
  • If applicable - New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@downiec downiec self-assigned this Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec78791) 98.54% compared to head (d650841) 98.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           v1.1.0     #604   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          76       76           
  Lines        2744     2744           
  Branches      416      416           
=======================================
  Hits         2704     2704           
  Misses         40       40           
Flag Coverage Δ
backend 100.00% <ø> (ø)
frontend 97.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@downiec downiec merged commit 136126b into v1.1.0 Feb 6, 2024
4 checks passed
@downiec downiec deleted the feature/591-add-facet-count-to-copy branch February 28, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants