Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom Solr port #607

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Support custom Solr port #607

merged 4 commits into from
Mar 12, 2024

Conversation

sashakames
Copy link
Collaborator

Currently, the Solr port is hardcoded to 80. This change supports custom ports.
Note this will be difficult to test at LLNL, we request support from partner sites that benefit from the change

@sashakames sashakames changed the base branch from master to v1.1.0 February 23, 2024 00:36
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b5dced7) to head (5f7c44b).

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.1.0      #607      +/-   ##
===========================================
+ Coverage   98.54%   100.00%   +1.45%     
===========================================
  Files          76        30      -46     
  Lines        2752       910    -1842     
  Branches      416         0     -416     
===========================================
- Hits         2712       910    -1802     
+ Misses         40         0      -40     
Flag Coverage Δ
backend 100.00% <ø> (ø)
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sashakames
Copy link
Collaborator Author

the branch was updated to v1.1.0 via merge. There are no frontend changes, so something is suspicious that the frontend CI fails, seems like another intermittent issue. Anyway I think we are ready for a review and should merge if no concerns.

@sashakames sashakames requested a review from downiec March 2, 2024 00:14
@sashakames sashakames merged commit b172ace into v1.1.0 Mar 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants