Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes local container #616

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Fixes local container #616

merged 6 commits into from
Mar 8, 2024

Conversation

jasonb5
Copy link
Collaborator

@jasonb5 jasonb5 commented Mar 4, 2024

Description

This PR updates the local container to utilize the production entrypoint. This solves three issues; the first is HTML not rendering in the news widget, the second is correctly rendering the index.html and runtime_env.js, and lastly fixing the runtime_env.js being written to the correct directory for local development.

Note that the index.html must continue to use $VAR rather than %VAR%. This enables runtime configuration, if %VAR% is used then the build process will substitute the values breaking runtime configuration.

Fixes # (issue)
#613

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Local Pre-commit Checks
  • CI/CD Build

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • If applicable - I have commented my code, particularly in hard-to-understand areas
  • If applicable - I have made corresponding changes to the documentation
  • If applicable - I have added tests that prove my fix is effective or that my feature works
  • If applicable - New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (caa6aec) to head (bd3af2b).

Additional details and impacted files
@@           Coverage Diff           @@
##           v1.1.0     #616   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          76       76           
  Lines        2752     2752           
  Branches      416      416           
=======================================
  Hits         2712     2712           
  Misses         40       40           
Flag Coverage Δ
backend 100.00% <ø> (ø)
frontend 97.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sashakames
Copy link
Collaborator

Is this another "intermittent" error?

       944 |
      945 |     // GitHub icon renders
    > 946 |     const metagridSupportHeader = findByText(' MetaGrid Support');
          |                                   ^
      947 |     expect(metagridSupportHeader).toBeTruthy();

@jasonb5
Copy link
Collaborator Author

jasonb5 commented Mar 6, 2024

There might be an issue specific to the Helm chart, looking into it now.

@jasonb5
Copy link
Collaborator Author

jasonb5 commented Mar 6, 2024

Confirmed need to make another change to this PR.

@jasonb5
Copy link
Collaborator Author

jasonb5 commented Mar 7, 2024

@sashakames @downiec Figured out the failing test, I forgot that the index.html needs to be manually rendered in the frontend testing workflow.

@jasonb5 jasonb5 merged commit 8adde79 into v1.1.0 Mar 8, 2024
6 checks passed
@jasonb5 jasonb5 deleted the fix_local_container branch March 8, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants