V1.1.2 rc test and bug fixes #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istence issue in saved endpoints so that they aren't lost when switching to the search or other metagrid pages.
…ts coverage to 100%, removed unnecessary lines and if statements from the class, removed unused persistData.ts file in favor of the Persister singleton. Fixed one of the facet forms tests. More tests need to be fixed due to the updated antd library changes.
…ling test in Facets component until it can be addressed. Updated DatasetDownload component to show 'Set Path' instead of 'Set New Path' since new may imply there was a path set before.
…y it fails to run the click handler. Made the wget download successful notice match across the app. Updated the js-pkce package.
downiec
added
Type: Bug
…at having it in the api folder. Fixed 3 tests to improve some coverage for dataset download component, created some test related functions and improvements. Fixed a frontend issue I found when no globus nodes are configured (to hide the globus ready column if it's not configured).
…ables rather that by clicking the app interface. Fixed a few more tests and brought the coverage up.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.1.2-rc #655 +/- ##
=============================================
Coverage ? 100.00%
=============================================
Files ? 30
Lines ? 946
Branches ? 0
=============================================
Hits ? 946
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…t aren't globus ready. It would continue with transfer even though it shouldn't. Fixed a few more tests and updated some packages. Removed unused refreshToken variable.
… functions for tests, to reduce repeated code and improve speed that tests are performed. Made some minor changes to dataset download based on things discovered during tests.
…ownload component. Fixed bug with wget download items (some undefined and null item selections were passing through to wget download causing an error). Updated server handlers for endpoint search tests. Increased timeout values for cart and app tests to see if they'll pass in github CI
…and stability using best practices. Fixed a test for facets form calendar, updated jest functions and added a fix to the facet form calendar component so that the tests would pass.
…or app and cart tests to see if they will pass
… Still need to troubleshoot why one test fails on github. Removed some unused atoms from globus state keys.
…. These can be adjusted later when tests are added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist