Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add fatal to Node.js API LintMessage type #14251

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

btmills
Copy link
Member

@btmills btmills commented Mar 25, 2021

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

fatal was missing from the LintMessage docs but is defined in the JSDoc type.

Is there anything you'd like reviewers to focus on?

@btmills btmills added documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Mar 25, 2021
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@mdjermanovic mdjermanovic merged commit c85c2f1 into master Apr 1, 2021
@mdjermanovic mdjermanovic deleted the docs-nodejs-api-lintmessage-type-fatal branch April 1, 2021 16:03
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Sep 29, 2021
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants