fix: basePath directory can never be ignored
#92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Just a reminder, we shouldn't be merging PRs that are opened over the weekend during the weekend. We need to give others a chance to review even if they're not online. (ref: when to merge) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Fixes a bug in
ConfigArray#isDirectoryIgnored().When
basePathdirectory is passed in as thedirectoryPathto check,isDirectoryIgnored()mistakenly checks/against ignore patterns. Then it can match, and thus returntrue, patterns like/(which should be no-op/invalid as an absolute path pattern) or**(which is valid but should not match thebasePathdirectory).What changes did you make? (Give an overview)
Fixed
isDirectoryIgnored()to always returnfalsefor thebasePathdirectory.Related Issues
refs eslint/eslint#18706
Is there anything you'd like reviewers to focus on?