Skip to content

Commit

Permalink
Remove references to the deprecated engine
Browse files Browse the repository at this point in the history
  • Loading branch information
softius committed Jul 27, 2024
1 parent d5411af commit 98779dc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions designs/2024-baseline-support/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ By default, the baseline file is saved at `.eslintbaseline` . To control where t
eslint --baseline --baseline-location /home/user/project/mycache
```

To implement this, we will need to add the two new options in `default-cli-options.js`, adjust the config for optionator and add the two new options as comments and arguments for both eslint and cli-engine. Documentation must be updated as well to explain the newly introduced options.
To implement this, we will need to add the two new options in `default-cli-options.js`, adjust the config for optionator and add the two new options as comments and arguments for both eslint. Documentation must be updated as well to explain the newly introduced options.

On top of that, we will need to adjust `cli.js` to check if `--baseline` was provided and set to true, right after the fixes are done and the warnings are filtered out, to avoid counting errors that are about to be fixed. A new method `generateBaseline` can be introduced in both `eslint.js` and `eslint-legacy.js` - the method must be called only and only if `--baseline` was provided and set to true.
On top of that, we will need to adjust `cli.js` to check if `--baseline` was provided and set to true, right after the fixes are done and the warnings are filtered out, to avoid counting errors that are about to be fixed. A new method `generateBaseline` can be introduced in both `eslint.js` - the method must be called only and only if `--baseline` was provided and set to true.

### Matching against the baseline

Expand Down

0 comments on commit 98779dc

Please sign in to comment.