Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Debug2Format from esp-hal #2184

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Remove Debug2Format from esp-hal #2184

merged 1 commit into from
Sep 18, 2024

Conversation

bugadani
Copy link
Contributor

We still have some uses in esp-backtrace (for PanicInfo) and esp-wifi (for multiple things), but at least not in esp-hal.

@bugadani bugadani added the skip-changelog No changelog modification needed label Sep 18, 2024
bjoernQ
bjoernQ approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MabezDev MabezDev added this pull request to the merge queue Sep 18, 2024
Merged via the queue into esp-rs:main with commit f765a6b Sep 18, 2024
27 checks passed
@bugadani bugadani deleted the defmt branch September 18, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ approved these changes

@MabezDev MabezDev MabezDev approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @bjoernQ @MabezDev