Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new boards pinout images for ESP32, ESP32-S2 and ESP32-C3 #5133

Merged
merged 1 commit into from
May 18, 2021
Merged

Added new boards pinout images for ESP32, ESP32-S2 and ESP32-C3 #5133

merged 1 commit into from
May 18, 2021

Conversation

pedrominatel
Copy link
Member

Updated images (suggestion) for the ESP32 DevKitC, ESP32-S2 Saola and ESP32-C3-DevKitM.

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2021

CLA assistant check
All committers have signed the CLA.

@pedrominatel
Copy link
Member Author

I can also add the SVG files if needed :)

@pedrominatel pedrominatel changed the title Added new boads pinout images for ESP32, ESP32-S2 and ESP32-C3 Added new boards pinout images for ESP32, ESP32-S2 and ESP32-C3 Apr 30, 2021
Copy link
Member

@igrr igrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like docs/_old_esp32_pinmap.png and docs/_old_esp32s2_pinmap.png aren't used anywhere, can they be removed?

@atanisoft
Copy link
Collaborator

@pedrominatel is it possible to add the default pull-up/down and other indicators to the new images that are present on the current ones?

@pedrominatel
Copy link
Member Author

Yes, it is @atanisoft. I'll update the images to include this information.

@lbernstone
Copy link
Contributor

pin46 on esp32-s2 is GPI, and really needs to be indicated somehow that it is input only.

@pedrominatel
Copy link
Member Author

Can you review @atanisoft?
@lbernstone, see the new indication on the GPIO46. Same as the ESP32-DevKitC.

@atanisoft
Copy link
Collaborator

atanisoft commented May 4, 2021

  1. esp32 34,35,36,39 and esp32-s2 46 should be GPI instead of GPIO (just to further clarify input only)
  2. Instead of WPU/WPD just use PU/PD (for all boards).
  3. If you can also add a legend to the images for what PU/PD/IE (input enabled)/ID (input disabled) all mean it would be great.
  4. a note should be added for esp32-s2 IO 26 as used for PSRAM on WROVER modules.

@pedrominatel
Copy link
Member Author

Hi @atanisoft thanks for your feedback!

  1. Why don't we use the same abbreviation found in the datasheet? It's easy to correlate when using the datasheet/TRM as reference.
  2. Same as above.
  3. Legend sounds good to have.
  4. I can add it.

@atanisoft
Copy link
Collaborator

  1. Why don't we use the same abbreviation found in the datasheet? It's easy to correlate when using the datasheet/TRM as reference.

Fine with me, just needs to be easy to read and understand in the image.

@pedrominatel
Copy link
Member Author

I'll change the color and add it to the legend :)

@atanisoft
Copy link
Collaborator

@pedrominatel the latest images look really nice!

One more rather minor change to the esp32 picture, if possible add a note about IO 6-11 being not usable by the application code.

Board images updated and added warning on Flash/PSRAM pins
@pedrominatel pedrominatel requested a review from igrr May 7, 2021 13:16
@pedrominatel
Copy link
Member Author

I've added the warning in the pins used by Flash/PSRAM on both boards (ESP32/S2). I also did some minor changes in some labels, according to the datasheet naming.

@me-no-dev me-no-dev merged commit cb2fbe4 into espressif:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants