Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analog Continuous mode API #8490

Closed
wants to merge 13 commits into from
Closed

Analog Continuous mode API #8490

wants to merge 13 commits into from

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Aug 4, 2023 •
edited
Loading

Description of Change

Added new API for running ADC peripheral in continuous mode, which enables ADC conversions to be non-blocking.

Updated documentation with new API + Added new example AnalogReadContinuous to demonstrate the usage.

Tests scenarios

Tested on all supported chips.

Related links

Related to #5205

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Peripherals API Relates to peripheral's APIs. label Aug 4, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.0.0 milestone Aug 4, 2023
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Aug 4, 2023
pedrominatel
pedrominatel reviewed Aug 10, 2023
View reviewed changes
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one point so far, @P-R-O-C-H-Y.

docs/source/api/adc.rst Show resolved Hide resolved
pedrominatel
pedrominatel reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor improvements.

docs/source/api/adc.rst Outdated Show resolved Hide resolved
docs/source/api/adc.rst Outdated Show resolved Hide resolved
@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this pull request Aug 16, 2023
Closed
@zuo785843091
Copy link

The following files are not found when compiling:
"esp_adc/adc_oneshot.h"
"esp_adc/adc_continuous.h"
"esp_adc/adc_cali_scheme.h"

@VojtechBartoska VojtechBartoska removed the request for review from PilnyTomas September 6, 2023 12:21
lucasssvaz
lucasssvaz approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@lucasssvaz lucasssvaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ESP32. Works as expected.
Just a suggestion to add a newline at the end of the .INO so the file is a valid text/source file in POSIX systems.

libraries/ESP32/examples/AnalogReadContinuous/AnalogReadContinuous.ino
Serial.println("Error occured during reading data. Set Core Debug Level to error or lower for more informations.");
}
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

pedrominatel
pedrominatel approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P-R-O-C-H-Y P-R-O-C-H-Y changed the base branch from esp-idf-v5.1-libs to master October 5, 2023 12:24
@P-R-O-C-H-Y P-R-O-C-H-Y changed the base branch from master to esp-idf-v5.1-libs October 5, 2023 12:25
@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this pull request Oct 5, 2023
Merged
@P-R-O-C-H-Y P-R-O-C-H-Y closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-no-dev me-no-dev me-no-dev left review comments

@pedrominatel pedrominatel pedrominatel approved these changes

@lucasssvaz lucasssvaz lucasssvaz approved these changes

@SuGlider SuGlider Awaiting requested review from SuGlider

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Peripherals API Relates to peripheral's APIs.
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@P-R-O-C-H-Y @zuo785843091 @pedrominatel @me-no-dev @lucasssvaz