Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for IDFGH-10379: Delay in esp_timer task callback prevents dispatch of ESP_TIMER_ISR callbacks (IDFGH-10380) #11637

Closed
wants to merge 1 commit into from
Closed

Fix for IDFGH-10379: Delay in esp_timer task callback prevents dispatch of ESP_TIMER_ISR callbacks (IDFGH-10380) #11637

wants to merge 1 commit into from

Conversation

acf-bwl
Copy link
Contributor

@acf-bwl acf-bwl commented Jun 9, 2023

A delay in an esp_timer task-dispatched callback can currently prevent ISR-dispatched callbacks from running until the former returns. This pull request introduces a fix for the issue. See IDFGH-10379

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

This was referenced Jun 9, 2023
Closed
Closed
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jun 9, 2023
@github-actions github-actions bot changed the title Fix for IDFGH-10379: Delay in esp_timer task callback prevents dispatch of ESP_TIMER_ISR callbacks Fix for IDFGH-10379: Delay in esp_timer task callback prevents dispatch of ESP_TIMER_ISR callbacks (IDFGH-10380) Jun 9, 2023
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@espressif-bot espressif-bot added Status: Selected for Development Issue is selected for development and removed Status: Opened Issue is new labels Jun 14, 2023
@KonstantinKondrashov
Copy link
Collaborator

Hi @acf-bwl! Thanks for the fix. That helps for the case that you described. I will take your changes. I will add some tests for this case and change your approach a little bit to reduce the amount of changes for the rest chips that use systimer.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Selected for Development Issue is selected for development labels Jul 17, 2023
espressif-bot pushed a commit that referenced this pull request Aug 28, 2023
@acf-bwl @KonstantinKondrashov
fix(esp_timer): Fix delay in ISR dispatch callbacks
41dc26f 
Set the following alarm before calling the alarm handler.

Closes #11637
Closes #11636
espressif-bot pushed a commit that referenced this pull request Sep 1, 2023
@acf-bwl @KonstantinKondrashov
fix(esp_timer): Fix delay in ISR dispatch callbacks
eef3a90 
Set the following alarm before calling the alarm handler.

Closes #11637
Closes #11636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KonstantinKondrashov KonstantinKondrashov

Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@acf-bwl @CLAassistant @Alvin1Zhang @KonstantinKondrashov @espressif-bot