-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable arm64 runner #601
Enable arm64 runner #601
Conversation
12d5875
to
9726ce2
Compare
Please sign a DCO |
It's almost identical to the existing workflow running on bbolt/.github/workflows/tests.yaml Lines 1 to 48 in a640695
|
i can create the template @ahrtr |
Sure, after this PR is merged (but it shouldn't block you work/investigate it for now. FYI. there is some examples under etcd workflow ). Please raise a followup ticket. |
9726ce2
to
4d30431
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ivanvc - Thanks for raising this, looks like a great start.
As mentioned above you just need to sign off your commit so the developer certificate of origin (DCO) check passes.
To do this you can run something like:
git reset --soft HEAD~1
git commit -s -a -m "Enable arm64 runner"
git push --force
Signed-off-by: Ivan Valdes <ivan@vald.es>
Hey @jmhbnz, I just did it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ivanvc!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks.
Enable tests to run on the ARM64 runner. Fixes #583.