Skip to content

Commit

Permalink
v3rpc: add jitter to progress notification
Browse files Browse the repository at this point in the history
  • Loading branch information
xiang90 committed Feb 5, 2018
1 parent 07f9229 commit 1e9d163
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion etcdserver/api/v3rpc/watch.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package v3rpc
import (
"context"
"io"
"math/rand"
"sync"
"time"

Expand Down Expand Up @@ -56,9 +57,14 @@ var (
)

func GetProgressReportInterval() time.Duration {
// add rand(1/10*progressReportInterval) as jitter so that etcdserver will not
// send progress notifications to watchers around the same time even when watchers
// are created around the same time (which is common when a client restarts itself).
jitter := time.Duration(rand.Int63n(int64(progressReportInterval) / 10))

progressReportIntervalMu.RLock()
defer progressReportIntervalMu.RUnlock()
return progressReportInterval
return progressReportInterval + jitter
}

func SetProgressReportInterval(newTimeout time.Duration) {
Expand Down

0 comments on commit 1e9d163

Please sign in to comment.