Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Benjamin Wang <wachao@vmware.com>
  • Loading branch information
logicalhan and ahrtr authored Jun 5, 2023
1 parent 28b8b9f commit 5a50e8e
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions server/etcdserver/api/etcdhttp/health.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,7 @@ func HandleLivez(lg *zap.Logger, mux *http.ServeMux, srv ServerHealth) {
if h := checkAlarms(lg, srv, excludedAlarms, endpoint); h.Health != "true" {
return h
}
// TODO(logicalhan) should we require quorum for livez?
return checkAPI(lg, srv, serializable)
return checkAPI(lg, srv, true)
}, PathLivez, []string{etcdserverpb.AlarmType_NOSPACE.String()}...))
}

Expand All @@ -79,7 +78,7 @@ func HandleReadyz(lg *zap.Logger, mux *http.ServeMux, srv ServerHealth) {
if h := checkAlarms(lg, srv, excludedAlarms, endpoint); h.Health != "true" {
return h
}
return checkAPI(lg, srv, serializable)
return checkAPI(lg, srv, false)
}, PathReadyz))
}

Expand Down

0 comments on commit 5a50e8e

Please sign in to comment.