Does the user need to eat all keep alive messages?

[helinwang]

When user keep alive a lease, the function KeepAlive returns a channel of keep alive messages. From the code in Session, it creates a net go-routine and eats all messages.
Is it necessary for the lease keep alive to work properly?

I am under impression that it does not have to
according to the code here, since the implementation just discard the message if the channel is full.

Just want to confirm if I need to add extra code to eat all the messages every time I create a lease and keep alive it.

[yudai]

AFIK, you virtually must drain messages from the channel returned by KeepAlive if the code has been not changed since #7446. Otherwise, keep alive messages are sent every 500ms to the server, as I reported in the issue.

[helinwang]

@yudai Thanks for the response! The issue you created is very informative! Yes the code is the same.

A side question, do your application actually care the result coming from the keep alive response channel? I am curious about the use case, maybe I could learn something to improve the program that I am currently working.

Thanks!
Helin

[yudai]

In my code, there are some code like for range keepAliveCh {}.
I actually don't have any use case that requires to check the content of messages to this channel so far.

[xiang90]

i think the question is well answered. thanks @yudai. closing.