Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3: modify lock type. #10595

Merged
merged 1 commit into from
Apr 30, 2019
Merged

clientv3: modify lock type. #10595

merged 1 commit into from
Apr 30, 2019

Conversation

johncming
Copy link
Contributor

@johncming johncming commented Mar 29, 2019

from #10580

  1. Concurrent access is possible in func (c *Client) Endpoints() (eps []string) , so mutex required.
  2. remove naked return.

@codecov-io
Copy link

Codecov Report

Merging #10595 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10595      +/-   ##
==========================================
+ Coverage    71.6%   71.66%   +0.06%     
==========================================
  Files         393      393              
  Lines       36571    36573       +2     
==========================================
+ Hits        26185    26211      +26     
+ Misses       8548     8527      -21     
+ Partials     1838     1835       -3
Impacted Files Coverage Δ
clientv3/client.go 80.22% <100%> (+0.11%) ⬆️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
etcdserver/api/v3rpc/lease.go 72.72% <0%> (-4.55%) ⬇️
etcdserver/v2_server.go 80.76% <0%> (-3.85%) ⬇️
lease/leasehttp/http.go 62.77% <0%> (-2.92%) ⬇️
etcdctl/ctlv3/command/printer_simple.go 72.48% <0%> (-1.35%) ⬇️
etcdserver/api/v2http/client.go 85.51% <0%> (-1.21%) ⬇️
proxy/grpcproxy/watch.go 88.55% <0%> (-1.21%) ⬇️
etcdserver/api/rafthttp/stream.go 79.39% <0%> (-0.43%) ⬇️
etcdserver/server.go 74.39% <0%> (-0.15%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be39aa5...9b5c468. Read the comment docs.

@gyuho
Copy link
Contributor

gyuho commented Mar 29, 2019

@johncming Can we investigate the test failures?

@johncming
Copy link
Contributor Author

@johncming Can we investigate the test failures?

ok, i will try it.

@xiang90
Copy link
Contributor

xiang90 commented Apr 30, 2019

lgtm

@xiang90 xiang90 merged commit 1bd02b2 into etcd-io:master Apr 30, 2019
gyuho added a commit that referenced this pull request May 2, 2019
From #10595.

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
hexfusion pushed a commit to openshift/etcd that referenced this pull request Sep 26, 2019
From etcd-io#10595.

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants