Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: watch stream got closed if one watch request is not permitted #11754

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

polyrabbit
Copy link
Contributor

This pr fixes #11708

The issue is easy to fix, but hard to reproduce. It happens only when:

  1. Client successfully established a watch stream
  2. Client issues another watch request which results in a permission denied response
  3. After that, every watch request that reuses the same stream will hang forever

@jingyih @gyuho @xiang90

@codecov-io
Copy link

codecov-io commented Apr 6, 2020

Codecov Report

Merging #11754 into master will decrease coverage by 0.81%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11754      +/-   ##
==========================================
- Coverage   66.55%   65.74%   -0.82%     
==========================================
  Files         403      403              
  Lines       36859    36860       +1     
==========================================
- Hits        24531    24233     -298     
- Misses      10841    11112     +271     
- Partials     1487     1515      +28     
Impacted Files Coverage Δ
etcdserver/api/v3rpc/watch.go 82.16% <0.00%> (-2.40%) ⬇️
client/client.go 43.13% <0.00%> (-40.85%) ⬇️
client/keys.go 68.34% <0.00%> (-23.12%) ⬇️
pkg/transport/timeout_conn.go 60.00% <0.00%> (-20.00%) ⬇️
auth/store.go 52.38% <0.00%> (-9.56%) ⬇️
pkg/logutil/zap_grpc.go 47.61% <0.00%> (-4.77%) ⬇️
proxy/grpcproxy/watcher.go 89.79% <0.00%> (-4.09%) ⬇️
clientv3/leasing/cache.go 87.77% <0.00%> (-3.89%) ⬇️
etcdserver/api/v3rpc/member.go 87.09% <0.00%> (-3.23%) ⬇️
clientv3/leasing/txn.go 88.09% <0.00%> (-3.18%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c623f79...73b936b. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Apr 6, 2020

LGTM. Defer to @jingyih

Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingyih jingyih merged commit 22e1bad into etcd-io:master Apr 6, 2020
spzala added a commit that referenced this pull request Apr 6, 2020
…4-upstream-release-3.4

Automated cherry pick of #11754 on release-3.4
gyuho added a commit that referenced this pull request Jun 22, 2020
…4-upstream-release-3.3

Automated cherry pick of #11754 on release-3.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

server stops listen watch stream requests if watch is not permitted
4 participants