Prepar to upgrade grpc version: grpc naming packge is moved in v1.30.0 #12609
Conversation
…v1.30.0, which will effect ectd naming package and grpcproxy package
skyao
changed the title
|
yay, so I think this one is better to merge instead of #12608 , bc naming interfaces moved to separate package |
I tried to run command And when I run |
|
For package naming in etcd, we need to make decision:
I copied the comment from xiang90 from #12398: |
|
For package naming in etcd, we need to make decision:
I copied the comment from xiang90 from #12398: Anyway, since grpc removed naming package and etcd naming package directly uses grpc naming package as method parameters, so there are must be some broken API changes when we update to new grpc version. func (gr *GRPCResolver) Update(ctx context.Context, target string, nm naming.Update, opts ...etcd.OpOption) (err error) {}
func (gr *GRPCResolver) Resolve(target string) (naming.Watcher, error) {}
func (gw *gRPCWatcher) Next() ([]*naming.Update, error) {}So the public API and document provided by etcd have to be updated ( with broken api changes): https://etcd.io/docs/v3.4.0/dev-guide/grpc_naming/ @ptabor @scDisorder How about proposal 2? If Ok, I will update this PR. |
|
for me prop2 are nice, but we should wait for @ptabor or someone from owners |
|
A.d. #12609 (comment), I see there A.d.. #12609 (comment) (Prop1, Prop2), let me do some experiment. I will go back by Tomorrow EOD, but intuitively to fullfill the usecase from (https://etcd.io/docs/v3.4.0/dev-guide/grpc_naming/) we need some code in client. Yes - it will be breaking change and we need to change the doc... but it's still supported by code in client (so I'm leaning toward some variant of prop1). |
Yes, I'm also surprised for this error. And in #12608 , scDisorder also found the same error. |
|
SemaphoreCI: https://semaphoreci.com/etcd-io/etcd/branches/pull-request-12609/builds/1 failed due to TestIssue6361 flake that I'm fixing in #12611. I don't see there proto-1.4 related problem. Also tried locally - but got success: (no protobuf-1.4.2 on the list above) |
As promised: As the target state for 3.5 naming API I would imagine following layout: TLDR: Please take a look at the proposed modified 3.5 naming user guide: |
|
I'm sorry: I pushed my clone of this branch that had not updated origin and (to my surprise) changed your exported branch. I recovered the original (Your) commit: 87eb299 |
|
@ptabor So what's the status now? Should I close this PR? |
|
Yes. Let's close it. I'm sorry for chiming in and taking up your time. #12652 tracks the current plan and help needed. |
Target: we want to upgrade grpc version from current v1.29.1 to new version (like v1.32.0)
Background: in grpc version v1.30.0, the grpc naming package is removed, which is used by ectd naming package and grpcproxy package
More information, please refrence to:
#12398