Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ineffassign #12793

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Correct ineffassign #12793

merged 1 commit into from
Mar 23, 2021

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Mar 22, 2021

@codecov-io
Copy link

Codecov Report

Merging #12793 (49d19ef) into master (8469108) will decrease coverage by 17.78%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #12793       +/-   ##
===========================================
- Coverage   73.04%   55.25%   -17.79%     
===========================================
  Files         427      406       -21     
  Lines       33163    32036     -1127     
===========================================
- Hits        24224    17703     -6521     
- Misses       7032    12486     +5454     
+ Partials     1907     1847       -60     
Flag Coverage Δ
all 55.25% <ø> (-17.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/mvcc/backend/read_tx.go 82.45% <ø> (-0.31%) ⬇️
pkg/pathutil/path.go 0.00% <0.00%> (-100.00%) ⬇️
raft/quorum/quorum.go 0.00% <0.00%> (-100.00%) ⬇️
raft/tracker/state.go 0.00% <0.00%> (-100.00%) ⬇️
client/v3/ordering/util.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/tlsutil/cipher_suites.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/transport/sockopt_unix.go 0.00% <0.00%> (-100.00%) ⬇️
client/v3/naming/endpoints/endpoints.go 0.00% <0.00%> (-100.00%) ⬇️
...ver/proxy/grpcproxy/adapter/lock_client_adapter.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/report/report.go 0.00% <0.00%> (-95.58%) ⬇️
... and 212 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8469108...49d19ef. Read the comment docs.

@ptabor ptabor merged commit 456e129 into etcd-io:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants