Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Support linearizable renew lease #13932

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Apr 12, 2022

Backport pull/13690 to release-3.5.

Original issue: issues/13675

When etcdserver receives a LeaseRenew request, it may be still in
progress of processing the LeaseGrantRequest on exact the same
leaseID. Accordingly it may return a TTL=0 to client due to the
leaseID not found error. So the leader should wait for the appliedID
to be available before processing client requests.
@ahrtr ahrtr force-pushed the lease_renew_linearizable_3.5 branch from 287ae6d to bc5307d Compare April 12, 2022 06:13
@ahrtr ahrtr changed the title support linearizable renew lease [3.5] Support linearizable renew lease Apr 12, 2022
@ahrtr
Copy link
Member Author

ahrtr commented Apr 12, 2022

This PR should be included in 3.5.3.

@ahrtr
Copy link
Member Author

ahrtr commented Apr 12, 2022

@serathius @ptabor @spzala

@serathius serathius mentioned this pull request Apr 12, 2022
28 tasks
@serathius serathius merged commit 719082e into etcd-io:release-3.5 Apr 12, 2022
ahrtr added a commit to ahrtr/etcd that referenced this pull request Jun 29, 2022
Cherry pick etcd-io#13932 to 3.4.

When etcdserver receives a LeaseRenew request, it may be still in
progress of processing the LeaseGrantRequest on exact the same
leaseID. Accordingly it may return a TTL=0 to client due to the
leaseID not found error. So the leader should wait for the appliedID
to be available before processing client requests.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
ahrtr added a commit to ahrtr/etcd that referenced this pull request Jun 30, 2022
Cherry pick etcd-io#13932 to 3.4.

When etcdserver receives a LeaseRenew request, it may be still in
progress of processing the LeaseGrantRequest on exact the same
leaseID. Accordingly it may return a TTL=0 to client due to the
leaseID not found error. So the leader should wait for the appliedID
to be available before processing client requests.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
@ahrtr ahrtr mentioned this pull request Jul 19, 2022
25 tasks
ahrtr added a commit to ahrtr/etcd that referenced this pull request Jul 19, 2022
Cherry pick etcd-io#13932 to 3.4.

When etcdserver receives a LeaseRenew request, it may be still in
progress of processing the LeaseGrantRequest on exact the same
leaseID. Accordingly it may return a TTL=0 to client due to the
leaseID not found error. So the leader should wait for the appliedID
to be available before processing client requests.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
tjungblu pushed a commit to tjungblu/etcd that referenced this pull request Sep 8, 2022
Cherry pick etcd-io#13932 to 3.4.

When etcdserver receives a LeaseRenew request, it may be still in
progress of processing the LeaseGrantRequest on exact the same
leaseID. Accordingly it may return a TTL=0 to client due to the
leaseID not found error. So the leader should wait for the appliedID
to be available before processing client requests.

Signed-off-by: Benjamin Wang <wachao@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants