lease: Rename Poll to Peek in the LeaseExpiredNotifier
#14198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serathius
approved these changes
Jul 7, 2022
serathius
reviewed
Jul 7, 2022
`Poll` means that the elements in the heap will be removed. And it is more appropriate to use `Peek` to get the top of the heap. Signed-off-by: SimFG <1142838399@qq.com>
|
@serathius yeah, I think it's better. |
SimFG
changed the title
Poll to Top in the LeaseExpiredNotifierPoll to Peek in the LeaseExpiredNotifier
|
Both It isn't a big deal, so approving this PR. |
ahrtr
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pollmeans that the elements in the heap will be removed.And it is more appropriate to use
Peekto get the top of the heap.Signed-off-by: SimFG 1142838399@qq.com