tests: Implement network delay and blackholing in linearizability tests #15048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
serathius
force-pushed
the
linearizability-network
branch
from
e904785
to
ddaa278
Compare
Codecov Report
@@ Coverage Diff @@
## main #15048 +/- ##
==========================================
- Coverage 74.72% 74.64% -0.09%
==========================================
Files 415 415
Lines 34273 34273
==========================================
- Hits 25611 25583 -28
- Misses 7026 7046 +20
- Partials 1636 1644 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
serathius
force-pushed
the
linearizability-network
branch
from
ddaa278
to
47a592f
Compare
lavacat
reviewed
Dec 27, 2022
| @@ -56,6 +56,8 @@ var ( | |||
| CompactBeforeCommitBatchPanic Failpoint = goPanicFailpoint{"compactBeforeCommitBatch", triggerCompact, AnyMember} | |||
| CompactAfterCommitBatchPanic Failpoint = goPanicFailpoint{"compactAfterCommitBatch", triggerCompact, AnyMember} | |||
| RaftBeforeLeaderSendPanic Failpoint = goPanicFailpoint{"raftBeforeLeaderSend", nil, Leader} | |||
| BlackholePeerNetwork Failpoint = blackholePeerNetworkFailpoint{duration: time.Second} | |||
There was a problem hiding this comment.
nit: have you considered adding target (Leader, Follower, Quorum, All)? Similar to current functional test cases
There was a problem hiding this comment.
For now I focused on getting proxy integrated into e2e. There are definitely couple of important cases in network functional failpoints that we should implement. Will add it to #14045
ptabor
approved these changes
Jan 4, 2023
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
linearizability-network
branch
from
47a592f
to
064fad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ahrtr @ptabor