Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC] store v2 deprecation #16000

Draft
wants to merge 48 commits into
base: main
Choose a base branch
from
Draft

[POC] store v2 deprecation #16000

wants to merge 48 commits into from

Conversation

geetasg
Copy link

@geetasg geetasg commented Jun 2, 2023 •
edited
Loading

This PR is not for review. It captures scope for #15905
Related to - #12913
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Geeta Gharpure and others added 30 commits May 15, 2023 17:00
Update ValidateConfigurationChange to nil check for v2store
e5ba13e 
Part of v2 deprecation changes

Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
v2d store RaftCluster membership info in v2 during snapshot
71c0a65 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
@geetasg
Merge branch 'etcd-io:main' into main
b57ceb0
updating based on test failure
a749ef4 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
updating to address test failure
9f66d43 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
refactor v2 deprecation change for snapshot
39a7837 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
persist "attributes" of member to new v2store
6798d77 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Adding unit test
11fa7d3 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
update v2 deprecation test
f55890c 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
update test
e467de9 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Adding test for recovering old version from v2 snapshot taken by new …
7a8bb94 
…version

Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
@geetasg
Merge branch 'etcd-io:main' into main
0b2fd5c
Add downgrade test that creates snapshots and keys
f41ed2e 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Add verification for consistent index
adac92b 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
start refactoring recovery logic
91359ba 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
update conf change validation
fa9b70b 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Stop v2 recovery during applySnapshot and bootstrap
543d305 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Deactivate v2store recovery for non-test only
8321280 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Adding comment to check back on v2discovery support
b44cb38 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Remove SetStore from etcdutl snapshot restore path
d8d0f62 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Update RaftCluster tests
dc2744f 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Refactor to create a function to return membership in v2 format
0ce6603 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Update backup command logic for saving membership to v2store
1976267 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Revert "Update backup command logic for saving membership to v2store"
0b4c9c6 
This reverts commit 1976267.
Robustness test failed..

Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
@geetasg
Merge branch 'etcd-io:main' into main
22855a9
Update server tests
8373547 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
update server unit tests
ea7d7f0 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Update consumers of RaftCluster SetStore
7dce310 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Update backup command to not use SetStore
7a1ae73 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Stop recovering membership info from v2store data
1bcd8c6 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Geeta Gharpure added 11 commits May 31, 2023 22:35
Disable v2 specific test. Revisit to rewrite for v3
f7b83bd 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Allow v2deprecation mode of write-only
338f747 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Remove SetStore method on RaftCluster
6e51502 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Update RemoveMember func to only use be
9605636 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Update function signature for recoverSnapshot
d9f149c 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Remove v2store from RaftCluster
8dcc34d 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Update function signature of bootstrapBackend
2db3039 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Remove v2store from bootstrap
930ecd2 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Use new v2store for etcdserver. Bootstrap does not return a store
9b0dd97 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Stop using v2store and v2applier from prod path
448f9ac 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Try out removing v2 applier
9c02d76 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
@ptabor ptabor changed the title Poc1 [Poc] store v2 deprecation Jun 3, 2023
@ptabor ptabor changed the title [Poc] store v2 deprecation [POC] store v2 deprecation Jun 3, 2023
Geeta Gharpure added 6 commits June 12, 2023 01:19
Use v2 to v3 applier only to handle publish from 3.5
733d109 
Drop other v2 requests

Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Fix comment
1bd5ae6 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Fix comment
21a1e44 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Fix goimport
a301201 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Add unit test for updateVersionV3
9515be1 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
Update TestApplyRequestOnAdminMemberAttributes to use v2v3 applier
d2323b7 
Signed-off-by: Geeta Gharpure <geetagh@amazon.com>
@geetasg geetasg mentioned this pull request Jun 13, 2023
Open
21 tasks
@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@ahrtr
Copy link
Member

ahrtr commented Oct 12, 2023

Please also rebase and tidyup this PR, I may also take a look sometime later.

@ahrtr ahrtr removed the stale label Oct 12, 2023
@stale Stale
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
@stale stale bot removed the stale label Jun 11, 2024
@k8s-ci-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-rebase
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geetasg @ahrtr @k8s-ci-robot