add tests for uber applier #16154
Merged
add tests for uber applier #16154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaochn47
reviewed
Jul 1, 2023
| }, | ||
| }}}, | ||
| expectError: nil, | ||
| }, |
There was a problem hiding this comment.
Could you please add an conditional delete in the Txn test case? It was the motivation of PR #13435
There was a problem hiding this comment.
Sure. Lemme check the background first.
There was a problem hiding this comment.
I can add a test case, but tbh I don't think that's the part of function I am trying to cover here......a better place would be the unit test of the server/storage package. However that package has no test coverage either. So nevermind, I will add it.
Signed-off-by: caojiamingalan <alan.c.19971111@gmail.com>
CaojiamingAlan
force-pushed
the
uber_applier_test
branch
from
72b4dfb
to
ffe73f9
Compare
chaochn47
approved these changes
Jul 1, 2023
jmhbnz
approved these changes
Jul 1, 2023
serathius
approved these changes
Jul 2, 2023
ahrtr
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16036
Add tests for uber applier.
Test cases involve building correct applier chains when alarms are on and off.