Add membership changes to downgrade tests #16457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
downgrade-membership
branch
from
f302209
to
1c0db87
Compare
ahrtr
reviewed
Aug 22, 2023
| if triggerSnapshot { | ||
| t.Logf("Generating snapshot") | ||
| generateSnapshot(t, snapshotCount, epc) | ||
| generateSnapshot(t, snapshotCount, cc) | ||
| verifySnapshot(t, epc) |
There was a problem hiding this comment.
Don't think this is needed. This is a downgrade/upgrade test, so from downgrade perspective we just need to confirm that members don't change during downgrade/upgrade procedure. Checking exact list of members is not in scope of the test. Aka, I would treat members as black box instead of whitebox.
ahrtr
approved these changes
Aug 22, 2023
|
lgtm. investigating additional test cases for downgrade |
|
Considering adding following scenarios -
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ahrtr @geetasg