Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Bump bbolt to 1.3.8 for release-3.4 #16834

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Oct 26, 2023

Signed-off-by: Benjamin Wang <wachao@vmware.com>
@ahrtr ahrtr changed the title Bump bbolt to 1.3.8 for release-3.4 [3.4] Bump bbolt to 1.3.8 for release-3.4 Oct 26, 2023
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM but can I just double check, is the intent that we will continue to backport each patch release for bbolt release-1.3 branch into etcd 3.4 and 3.5 stable releases, or is it case by case depending on what each patch release of bbolt actually contains?

@chaochn47
Copy link
Member

Code change LGTM but can I just double check, is the intent that we will continue to backport each patch release for bbolt release-1.3 branch into etcd 3.4 and 3.5 stable releases, or is it case by case depending on what each patch release of bbolt actually contains?

I guess patch version update is backportable while etcd 3.6 will depend on bbolt 1.4 like https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/roadmap.md documented.

@ahrtr
Copy link
Member Author

ahrtr commented Oct 27, 2023

  • v1.3.8 has a couple of bug fixes, such as panicking on arm32 etc. It's highly recommended to bump the version. Especially we will support 3.4 for a long time ( > 0.5 years). (Note actually many people are still not willing/ready to upgrade to 3.5);
  • If you compare the differences between 1.3.7 and 1.3.8, it should be safe.
  • I wish 1.3.8 is the last patch for bbolt release-1.3.

@ahrtr ahrtr merged commit 5801fbd into etcd-io:release-3.4 Oct 27, 2023
12 checks passed
@ahrtr ahrtr mentioned this pull request Oct 27, 2023
14 tasks
@ahrtr ahrtr deleted the 3.4_bump_bbolt_1.3.8_20231026 branch June 12, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants